Villanova Assignments for Code Review
Assignments are listed below for number of Villanova students who will perform a detailed code review of a specified portion of program source code produced by our TCNJ partners. Completed assignments are posted in the first section below called "Completed Reviews."
Completed Reviews
Using these reviews: Each zip file below contains one or more documents that contain a sample (class) of code (see Individual Assignments) and embedded comments. Comments are intended to be constructive, and may sound very terse or harsh, but are not intended to be judgemental at all. We tried to keep things short and sweet, so the comments are brief and meant as suggestions, comments, or ideas for how the reviewer thinks that the code might be improved in some way.
Review Procedure
To perform the review, you should copy the source code into a document file (e.g., MS Word or other convenient application that allows embedded annotations and highlighted comments). The source code is contained in two zip files (rice.zip & collisionManager.zip). Download the appropriate file and locate the code you have been assigned to review. More details on this assignment are available here, and general assignment questions should be referred to Dr. Way. Specific questions about the code should be directed to the TCNJ student, or students, who authored the code, or to the TCNJ liaisons for the games of which this code is a part.
Villanova students welcome contact from any of their colleagues at TCNJ who can assist in understanding the code being reviewed.
The deadline for completing this review is: Tuesday, March 31, 2009
Review the code for the following;
- Suggestions for restructuring of code to improve modularity
- Suggestions for renaming variables, classes, methods, etc.
- Suggestions for improving efficiency of algorithms being used
- Suggestions for additional comments in the code
- Notes about any possible bugs you found in the code
- In general, suggestions that can be used to improve the code in some way
When reviewing, place your comments and suggestions near the code pertaining to the specific comments or suggestions and be sure to highlight them or otherwise separate them in some way from the code so that it is easy to tell the comments and suggestsions from the code.
Note: it is not sufficient to say "nice code" or "good job". You need to find concrete ways that the code can be improved in some way, either in terms of on or more of: long-term maintainability, possible bugs, efficiency, modularity or refactoring.
Individual Assignments
The following Villanova students are assigned the designated ports of code. Contact information for students is on the Villanova Team Assets page.
| Code |
Reviewers |
| rice::World.pde |
John Barthmaier |
| rice::Animation.pde |
Chris Miller |
| rice::AnimationManager.pde |
Vince Vuono |
| rice::TextureManager.pde |
AJ Palkovic & John McCoey |
| rice::SoundCore.pde |
Chris Danner |
| rice::ResourceCollection.pde |
Xavier Halloran & Aaren McLucas |
| rice::Map.pde,Layer.pde,Tile.pde |
Michael Hercenberg |
| rice::InputCore.pde |
John Roland, Mat Goldsborough & Lou Criso |
| rice::GraphicsCore.pde,Camera.pde |
Joe Charpentier & Elliot Whaley |
| rice::rice.java |
Jake Sabulsky |
| GameEngine::collisionManager.pde, HitBox.pde |
Andrew Chickadel |
Comments (0)
You don't have permission to comment on this page.